UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

platform/x86: intel_telemetry_debugfs: Respect error code of kstrtou32_from_user() 

kstrtou32_from_user() may return different error codes on certain
circumstances. Respect all possible values.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Andy Shevchenko 2019-12-18 20:42:29 +02:00
parent cbe358191f
commit 4475e69927
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/platform/x86/intel_telemetry_debugfs.c
View File

@ -686,13 +686,14 @@ static ssize_t telem_pss_trc_verb_write(struct file *file,
u32 verbosity; u32 verbosity;
int err; int err;
if (kstrtou32_from_user(userbuf, count, 0, &verbosity)) err = kstrtou32_from_user(userbuf, count, 0, &verbosity);
return -EFAULT; if (err)
return err;
err = telemetry_set_trace_verbosity(TELEM_PSS, verbosity); err = telemetry_set_trace_verbosity(TELEM_PSS, verbosity);
if (err) { if (err) {
pr_err("Changing PSS Trace Verbosity Failed. Error %d\n", err); pr_err("Changing PSS Trace Verbosity Failed. Error %d\n", err);
count = err; return err;
} }
return count; return count;
@ -733,13 +734,14 @@ static ssize_t telem_ioss_trc_verb_write(struct file *file,
u32 verbosity; u32 verbosity;
int err; int err;
if (kstrtou32_from_user(userbuf, count, 0, &verbosity)) err = kstrtou32_from_user(userbuf, count, 0, &verbosity);
return -EFAULT; if (err)
return err;
err = telemetry_set_trace_verbosity(TELEM_IOSS, verbosity); err = telemetry_set_trace_verbosity(TELEM_IOSS, verbosity);
if (err) { if (err) {
pr_err("Changing IOSS Trace Verbosity Failed. Error %d\n", err); pr_err("Changing IOSS Trace Verbosity Failed. Error %d\n", err);
count = err; return err;
} }
return count; return count;