KVM: x86: introduce kvm_check_has_quirk
The logic of the disabled_quirks field usually results in a double negation. Wrap it in a simple function that checks the bit and negates it. Based on a patch from Xiao Guangrong. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
3e5d2fdced
commit
41dbc6bcd9
|
@ -1595,7 +1595,7 @@ void kvm_lapic_reset(struct kvm_vcpu *vcpu, bool init_event)
|
||||||
for (i = 0; i < APIC_LVT_NUM; i++)
|
for (i = 0; i < APIC_LVT_NUM; i++)
|
||||||
apic_set_reg(apic, APIC_LVTT + 0x10 * i, APIC_LVT_MASKED);
|
apic_set_reg(apic, APIC_LVTT + 0x10 * i, APIC_LVT_MASKED);
|
||||||
apic_update_lvtt(apic);
|
apic_update_lvtt(apic);
|
||||||
if (!(vcpu->kvm->arch.disabled_quirks & KVM_QUIRK_LINT0_REENABLED))
|
if (kvm_check_has_quirk(vcpu->kvm, KVM_QUIRK_LINT0_REENABLED))
|
||||||
apic_set_reg(apic, APIC_LVT0,
|
apic_set_reg(apic, APIC_LVT0,
|
||||||
SET_APIC_DELIVERY_MODE(0, APIC_MODE_EXTINT));
|
SET_APIC_DELIVERY_MODE(0, APIC_MODE_EXTINT));
|
||||||
apic_manage_nmi_watchdog(apic, kvm_apic_get_reg(apic, APIC_LVT0));
|
apic_manage_nmi_watchdog(apic, kvm_apic_get_reg(apic, APIC_LVT0));
|
||||||
|
|
|
@ -1672,7 +1672,7 @@ static void svm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
|
||||||
* does not do it - this results in some delay at
|
* does not do it - this results in some delay at
|
||||||
* reboot
|
* reboot
|
||||||
*/
|
*/
|
||||||
if (!(vcpu->kvm->arch.disabled_quirks & KVM_QUIRK_CD_NW_CLEARED))
|
if (kvm_check_has_quirk(vcpu->kvm, KVM_QUIRK_CD_NW_CLEARED))
|
||||||
cr0 &= ~(X86_CR0_CD | X86_CR0_NW);
|
cr0 &= ~(X86_CR0_CD | X86_CR0_NW);
|
||||||
svm->vmcb->save.cr0 = cr0;
|
svm->vmcb->save.cr0 = cr0;
|
||||||
mark_dirty(svm->vmcb, VMCB_CR);
|
mark_dirty(svm->vmcb, VMCB_CR);
|
||||||
|
|
|
@ -147,6 +147,11 @@ static inline void kvm_register_writel(struct kvm_vcpu *vcpu,
|
||||||
return kvm_register_write(vcpu, reg, val);
|
return kvm_register_write(vcpu, reg, val);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static inline bool kvm_check_has_quirk(struct kvm *kvm, u64 quirk)
|
||||||
|
{
|
||||||
|
return !(kvm->arch.disabled_quirks & quirk);
|
||||||
|
}
|
||||||
|
|
||||||
void kvm_before_handle_nmi(struct kvm_vcpu *vcpu);
|
void kvm_before_handle_nmi(struct kvm_vcpu *vcpu);
|
||||||
void kvm_after_handle_nmi(struct kvm_vcpu *vcpu);
|
void kvm_after_handle_nmi(struct kvm_vcpu *vcpu);
|
||||||
void kvm_set_pending_timer(struct kvm_vcpu *vcpu);
|
void kvm_set_pending_timer(struct kvm_vcpu *vcpu);
|
||||||
|
|
Loading…
Reference in New Issue