UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_ioremap 

Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Vivek Gautam 2014-05-10 17:30:07 +05:30 committed by Greg Kroah-Hartman
parent 70843f623b
commit 40a5ec988c
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/usb/host/ehci-mv.c
View File

@ -176,11 +176,9 @@ static int mv_ehci_probe(struct platform_device *pdev)
goto err_put_hcd; goto err_put_hcd;
} }
ehci_mv->phy_regs = devm_ioremap(&pdev->dev, r->start, ehci_mv->phy_regs = devm_ioremap_resource(&pdev->dev, r);
resource_size(r)); if (IS_ERR(ehci_mv->phy_regs)) {
if (!ehci_mv->phy_regs) { retval = PTR_ERR(ehci_mv->phy_regs);
dev_err(&pdev->dev, "failed to map phy I/O memory\n");
retval = -EFAULT;
goto err_put_hcd; goto err_put_hcd;
} }
@ -191,11 +189,9 @@ static int mv_ehci_probe(struct platform_device *pdev)
goto err_put_hcd; goto err_put_hcd;
} }
ehci_mv->cap_regs = devm_ioremap(&pdev->dev, r->start, ehci_mv->cap_regs = devm_ioremap_resource(&pdev->dev, r);
resource_size(r)); if (IS_ERR(ehci_mv->cap_regs)) {
if (ehci_mv->cap_regs == NULL) { retval = PTR_ERR(ehci_mv->cap_regs);
dev_err(&pdev->dev, "failed to map I/O memory\n");
retval = -EFAULT;
goto err_put_hcd; goto err_put_hcd;
} }