tools/libbpf: signedness bug in btf_dedup_ref_type()

The "ref_type_id" variable needs to be signed for the error handling
to work.

Fixes: d5caef5b56 ("btf: add BTF types deduplication algorithm")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
Dan Carpenter 2019-02-28 21:06:47 +03:00 committed by Daniel Borkmann
parent 74b3881908
commit 3d8669e637
1 changed files with 2 additions and 1 deletions

View File

@ -2326,7 +2326,8 @@ static int btf_dedup_ref_type(struct btf_dedup *d, __u32 type_id)
struct btf_type *t, *cand; struct btf_type *t, *cand;
/* if we don't find equivalent type, then we are representative type */ /* if we don't find equivalent type, then we are representative type */
__u32 new_id = type_id; __u32 new_id = type_id;
__u32 h, ref_type_id; int ref_type_id;
__u32 h;
if (d->map[type_id] == BTF_IN_PROGRESS_ID) if (d->map[type_id] == BTF_IN_PROGRESS_ID)
return -ELOOP; return -ELOOP;