drm/radeon: Unbreak HPD handling for r600+
We end up reading the interrupt register for HPD5, and then writing it to HPD6 which on systems without anything using HPD5 results in permanently disabling hotplug on one of the display outputs after the first time we acknowledge a hotplug interrupt from the GPU. This code is really bad. But for now, let's just fix this. I will hopefully have a large patch series to refactor all of this soon. Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Lyude <lyude@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
parent
2275a3a2fe
commit
3d18e33735
|
@ -7401,7 +7401,7 @@ static inline void cik_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.cik.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
if (rdev->irq.stat_regs.cik.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_INT_ACK;
|
tmp |= DC_HPDx_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
@ -7431,7 +7431,7 @@ static inline void cik_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.cik.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
if (rdev->irq.stat_regs.cik.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_RX_INT_ACK;
|
tmp |= DC_HPDx_RX_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
|
|
@ -4927,7 +4927,7 @@ static void evergreen_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_INT_ACK;
|
tmp |= DC_HPDx_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
@ -4958,7 +4958,7 @@ static void evergreen_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_RX_INT_ACK;
|
tmp |= DC_HPDx_RX_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
|
|
@ -3988,7 +3988,7 @@ static void r600_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.r600.disp_int_cont2 & DC_HPD6_INTERRUPT) {
|
if (rdev->irq.stat_regs.r600.disp_int_cont2 & DC_HPD6_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_INT_ACK;
|
tmp |= DC_HPDx_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
|
|
@ -6317,7 +6317,7 @@ static inline void si_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_INT_ACK;
|
tmp |= DC_HPDx_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
@ -6348,7 +6348,7 @@ static inline void si_irq_ack(struct radeon_device *rdev)
|
||||||
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
WREG32(DC_HPD5_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
if (rdev->irq.stat_regs.evergreen.disp_int_cont5 & DC_HPD6_RX_INTERRUPT) {
|
||||||
tmp = RREG32(DC_HPD5_INT_CONTROL);
|
tmp = RREG32(DC_HPD6_INT_CONTROL);
|
||||||
tmp |= DC_HPDx_RX_INT_ACK;
|
tmp |= DC_HPDx_RX_INT_ACK;
|
||||||
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
WREG32(DC_HPD6_INT_CONTROL, tmp);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue