UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

[CRYPTO]: Kill unnecessary strncpy from tcrypt 

It seems that bad code tends to get copied (see test_cipher_speed).  So let's
kill this idiom before it spreads any further.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Herbert Xu 2005-06-22 13:26:36 -07:00 committed by David S. Miller
parent ef2736fc74
commit 3cc3816f93
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crypto/tcrypt.c
View File

@ -266,16 +266,16 @@ static void test_cipher(char *algo, int mode, int enc,
char *key;
struct cipher_testvec *cipher_tv;
struct scatterlist sg[8];
char e[11], m[4];
const char *e, *m;
if (enc == ENCRYPT)
strncpy(e, "encryption", 11);
e = "encryption";
else
strncpy(e, "decryption", 11);
e = "decryption";
if (mode == MODE_ECB)
strncpy(m, "ECB", 4);
m = "ECB";
else
strncpy(m, "CBC", 4);
m = "CBC";
printk("\ntesting %s %s %s\n", algo, m, e);