ARM: exynos: Remove static mapping of SCU SFR

Lets remove static mapping of SCU SFR mainly used in CORTEX-A9 SoC based
boards. Instead use mapping from device tree node of SCU.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
[mszyprow: rebased, added fallback to scu_a9_get_base() when no SCU DT
 node is available, removed compatibility break warning, fixed non-SMP
 build, keep SCU base mapping to avoid issues with calls from CPUidle]
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
This commit is contained in:
Pankaj Dubey 2018-05-10 13:02:54 +02:00 committed by Krzysztof Kozlowski
parent 66df44b258
commit 3c33710b45
7 changed files with 28 additions and 40 deletions

View File

@ -141,6 +141,11 @@ extern void exynos_cpu_restore_register(void);
extern void exynos_pm_central_suspend(void); extern void exynos_pm_central_suspend(void);
extern int exynos_pm_central_resume(void); extern int exynos_pm_central_resume(void);
extern void exynos_enter_aftr(void); extern void exynos_enter_aftr(void);
#ifdef CONFIG_SMP
extern void exynos_scu_enable(void);
#else
static inline void exynos_scu_enable(void) { }
#endif
extern struct cpuidle_exynos_data cpuidle_coupled_exynos_data; extern struct cpuidle_exynos_data cpuidle_coupled_exynos_data;

View File

@ -24,15 +24,6 @@
#include "common.h" #include "common.h"
static struct map_desc exynos4_iodesc[] __initdata = {
{
.virtual = (unsigned long)S5P_VA_COREPERI_BASE,
.pfn = __phys_to_pfn(EXYNOS4_PA_COREPERI),
.length = SZ_8K,
.type = MT_DEVICE,
},
};
static struct platform_device exynos_cpuidle = { static struct platform_device exynos_cpuidle = {
.name = "exynos_cpuidle", .name = "exynos_cpuidle",
#ifdef CONFIG_ARM_EXYNOS_CPUIDLE #ifdef CONFIG_ARM_EXYNOS_CPUIDLE
@ -85,17 +76,6 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,
return 1; return 1;
} }
/*
* exynos_map_io
*
* register the standard cpu IO areas
*/
static void __init exynos_map_io(void)
{
if (soc_is_exynos4())
iotable_init(exynos4_iodesc, ARRAY_SIZE(exynos4_iodesc));
}
static void __init exynos_init_io(void) static void __init exynos_init_io(void)
{ {
debug_ll_io_init(); debug_ll_io_init();
@ -104,8 +84,6 @@ static void __init exynos_init_io(void)
/* detect cpu id and rev. */ /* detect cpu id and rev. */
s5p_init_cpu(S5P_VA_CHIPID); s5p_init_cpu(S5P_VA_CHIPID);
exynos_map_io();
} }
/* /*

View File

@ -15,6 +15,4 @@
#define EXYNOS_PA_CHIPID 0x10000000 #define EXYNOS_PA_CHIPID 0x10000000
#define EXYNOS4_PA_COREPERI 0x10500000
#endif /* __ASM_ARCH_MAP_H */ #endif /* __ASM_ARCH_MAP_H */

View File

@ -163,6 +163,26 @@ int exynos_cluster_power_state(int cluster)
S5P_CORE_LOCAL_PWR_EN); S5P_CORE_LOCAL_PWR_EN);
} }
/**
* exynos_scu_enable : enables SCU for Cortex-A9 based system
*/
void exynos_scu_enable(void)
{
struct device_node *np;
static void __iomem *scu_base;
if (!scu_base) {
np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-scu");
if (np) {
scu_base = of_iomap(np, 0);
of_node_put(np);
} else {
scu_base = ioremap(scu_a9_get_base(), SZ_4K);
}
}
scu_enable(scu_base);
}
static void __iomem *cpu_boot_reg_base(void) static void __iomem *cpu_boot_reg_base(void)
{ {
if (soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_1_1) if (soc_is_exynos4210() && samsung_rev() == EXYNOS4210_REV_1_1)
@ -219,11 +239,6 @@ static void write_pen_release(int val)
sync_cache_w(&pen_release); sync_cache_w(&pen_release);
} }
static void __iomem *scu_base_addr(void)
{
return (void __iomem *)(S5P_VA_SCU);
}
static DEFINE_SPINLOCK(boot_lock); static DEFINE_SPINLOCK(boot_lock);
static void exynos_secondary_init(unsigned int cpu) static void exynos_secondary_init(unsigned int cpu)
@ -389,7 +404,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
exynos_set_delayed_reset_assertion(true); exynos_set_delayed_reset_assertion(true);
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
scu_enable(scu_base_addr()); exynos_scu_enable();
/* /*
* Write the address of secondary startup into the * Write the address of secondary startup into the

View File

@ -22,8 +22,6 @@
#include <asm/suspend.h> #include <asm/suspend.h>
#include <asm/cacheflush.h> #include <asm/cacheflush.h>
#include <mach/map.h>
#include "common.h" #include "common.h"
static inline void __iomem *exynos_boot_vector_addr(void) static inline void __iomem *exynos_boot_vector_addr(void)
@ -172,7 +170,7 @@ void exynos_enter_aftr(void)
cpu_suspend(0, exynos_aftr_finisher); cpu_suspend(0, exynos_aftr_finisher);
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) { if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) {
scu_enable(S5P_VA_SCU); exynos_scu_enable();
if (call_firmware_op(resume) == -ENOSYS) if (call_firmware_op(resume) == -ENOSYS)
exynos_cpu_restore_register(); exynos_cpu_restore_register();
} }

View File

@ -30,8 +30,6 @@
#include <asm/smp_scu.h> #include <asm/smp_scu.h>
#include <asm/suspend.h> #include <asm/suspend.h>
#include <mach/map.h>
#include <plat/pm-common.h> #include <plat/pm-common.h>
#include "common.h" #include "common.h"
@ -401,7 +399,7 @@ static void exynos_pm_resume(void)
goto early_wakeup; goto early_wakeup;
if (cpuid == ARM_CPU_PART_CORTEX_A9) if (cpuid == ARM_CPU_PART_CORTEX_A9)
scu_enable(S5P_VA_SCU); exynos_scu_enable();
if (call_firmware_op(resume) == -ENOSYS if (call_firmware_op(resume) == -ENOSYS
&& cpuid == ARM_CPU_PART_CORTEX_A9) && cpuid == ARM_CPU_PART_CORTEX_A9)

View File

@ -11,10 +11,6 @@
#define S5P_VA_CHIPID S3C_ADDR(0x02000000) #define S5P_VA_CHIPID S3C_ADDR(0x02000000)
#define S5P_VA_COREPERI_BASE S3C_ADDR(0x02800000)
#define S5P_VA_COREPERI(x) (S5P_VA_COREPERI_BASE + (x))
#define S5P_VA_SCU S5P_VA_COREPERI(0x0)
#define VA_VIC(x) (S3C_VA_IRQ + ((x) * 0x10000)) #define VA_VIC(x) (S3C_VA_IRQ + ((x) * 0x10000))
#define VA_VIC0 VA_VIC(0) #define VA_VIC0 VA_VIC(0)
#define VA_VIC1 VA_VIC(1) #define VA_VIC1 VA_VIC(1)