UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages 

The decision was made a few months ago to allow struct omap_hwmod
records and struct clk records to omit clockdomain information if the
clockdomain is not software-controllable.  See for example commit
868c157df9 ("ARM: OMAP2+: hwmod: remove
prm_clkdm, cm_clkdm; allow hwmods to have no clockdomain").

So convert an existing pr_warning() to a pr_debug() (regarding missing
clockdomains in clocks), and add a pr_debug() for missing hwmod
clockdomains.  It's still useful to enable these messages for
debugging, since missing clockdomains can cause hard-to-debug problems
with power management; see for example commit
6c4a057bff ("ARM: OMAP4: clock data:
Force a DPLL clkdm/pwrdm ON before a relock").

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Benoît Cousson <b-cousson@ti.com>
This commit is contained in:
Paul Walmsley 2012-09-23 17:28:18 -06:00
parent 2b026d137b
commit 3bb05dbf69
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/arm/mach-omap2/omap_hwmod.c
View File

@ -696,7 +696,7 @@ static int _init_main_clk(struct omap_hwmod *oh)
clk_prepare(oh->_clk); clk_prepare(oh->_clk);
if (!oh->_clk->clkdm) if (!oh->_clk->clkdm)
pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n", pr_debug("omap_hwmod: %s: missing clockdomain for %s.\n",
oh->name, oh->main_clk); oh->name, oh->main_clk);
return ret; return ret;
@ -1454,8 +1454,10 @@ static struct omap_hwmod *_lookup(const char *name)
*/ */
static int _init_clkdm(struct omap_hwmod *oh) static int _init_clkdm(struct omap_hwmod *oh)
{ {
if (!oh->clkdm_name) if (!oh->clkdm_name) {
pr_debug("omap_hwmod: %s: missing clockdomain\n", oh->name);
return 0; return 0;
}
oh->clkdm = clkdm_lookup(oh->clkdm_name); oh->clkdm = clkdm_lookup(oh->clkdm_name);
if (!oh->clkdm) { if (!oh->clkdm) {