UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

PCI: altera: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/linux-pci/20230321193208.366561-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-21 20:31:55 +01:00 committed by Krzysztof Wilczyński
parent b11c76db97
commit 3a610560aa
No known key found for this signature in database
GPG Key ID: 7C64768D3DE334E7
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pci/controller/pcie-altera.c
View File

@ -806,7 +806,7 @@ static int altera_pcie_probe(struct platform_device *pdev)
return pci_host_probe(bridge); return pci_host_probe(bridge);
} }
static int altera_pcie_remove(struct platform_device *pdev) static void altera_pcie_remove(struct platform_device *pdev)
{ {
struct altera_pcie *pcie = platform_get_drvdata(pdev); struct altera_pcie *pcie = platform_get_drvdata(pdev);
struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie); struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie);
@ -814,13 +814,11 @@ static int altera_pcie_remove(struct platform_device *pdev)
pci_stop_root_bus(bridge->bus); pci_stop_root_bus(bridge->bus);
pci_remove_root_bus(bridge->bus); pci_remove_root_bus(bridge->bus);
altera_pcie_irq_teardown(pcie); altera_pcie_irq_teardown(pcie);
return 0;
} }
static struct platform_driver altera_pcie_driver = { static struct platform_driver altera_pcie_driver = {
.probe = altera_pcie_probe, .probe = altera_pcie_probe,
.remove = altera_pcie_remove, .remove_new = altera_pcie_remove,
.driver = { .driver = {
.name = "altera-pcie", .name = "altera-pcie",
.of_match_table = altera_pcie_of_match, .of_match_table = altera_pcie_of_match,