UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

[PATCH] libata: sync result_tf.flags w/ command tf.flags 

libata didn't initialize result_tf.flags which indicates transfer type
(RW/FUA) and address type (CHS/LBA/LBA48).  ata_gen_fixed_sense()
assumed result_tf.flags equals command tf.flags and failed to report
the first failed block to SCSI layer because zero tf flags indicates
CHS and bad block reporting for CHS is not implemented.

Implement fill_result_tf() which sets result_tf.flags to command
tf.flags and use it to fill result_tf.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Tejun Heo 2006-11-14 22:37:35 +09:00 committed by Jeff Garzik
parent 61c0596c5f
commit 39599a5334
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/ata/libata-core.c
View File

@ -4536,6 +4536,14 @@ void __ata_qc_complete(struct ata_queued_cmd *qc)
qc->complete_fn(qc); qc->complete_fn(qc);
} }
static void fill_result_tf(struct ata_queued_cmd *qc)
{
struct ata_port *ap = qc->ap;
ap->ops->tf_read(ap, &qc->result_tf);
qc->result_tf.flags = qc->tf.flags;
}
/** /**
* ata_qc_complete - Complete an active ATA command * ata_qc_complete - Complete an active ATA command
* @qc: Command to complete * @qc: Command to complete
@ -4573,7 +4581,7 @@ void ata_qc_complete(struct ata_queued_cmd *qc)
if (unlikely(qc->flags & ATA_QCFLAG_FAILED)) { if (unlikely(qc->flags & ATA_QCFLAG_FAILED)) {
if (!ata_tag_internal(qc->tag)) { if (!ata_tag_internal(qc->tag)) {
/* always fill result TF for failed qc */ /* always fill result TF for failed qc */
ap->ops->tf_read(ap, &qc->result_tf); fill_result_tf(qc);
ata_qc_schedule_eh(qc); ata_qc_schedule_eh(qc);
return; return;
} }
@ -4581,7 +4589,7 @@ void ata_qc_complete(struct ata_queued_cmd *qc)
/* read result TF if requested */ /* read result TF if requested */
if (qc->flags & ATA_QCFLAG_RESULT_TF) if (qc->flags & ATA_QCFLAG_RESULT_TF)
ap->ops->tf_read(ap, &qc->result_tf); fill_result_tf(qc);
__ata_qc_complete(qc); __ata_qc_complete(qc);
} else { } else {
@ -4590,7 +4598,7 @@ void ata_qc_complete(struct ata_queued_cmd *qc)
/* read result TF if failed or requested */ /* read result TF if failed or requested */
if (qc->err_mask || qc->flags & ATA_QCFLAG_RESULT_TF) if (qc->err_mask || qc->flags & ATA_QCFLAG_RESULT_TF)
ap->ops->tf_read(ap, &qc->result_tf); fill_result_tf(qc);
__ata_qc_complete(qc); __ata_qc_complete(qc);
} }