[media] zr36067: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
8ba6220fe3
commit
37320d7bc0
|
@ -708,8 +708,7 @@ static const struct i2c_algo_bit_data zoran_i2c_bit_data_template = {
|
|||
static int
|
||||
zoran_register_i2c (struct zoran *zr)
|
||||
{
|
||||
memcpy(&zr->i2c_algo, &zoran_i2c_bit_data_template,
|
||||
sizeof(struct i2c_algo_bit_data));
|
||||
zr->i2c_algo = zoran_i2c_bit_data_template;
|
||||
zr->i2c_algo.data = zr;
|
||||
strlcpy(zr->i2c_adapter.name, ZR_DEVNAME(zr),
|
||||
sizeof(zr->i2c_adapter.name));
|
||||
|
|
Loading…
Reference in New Issue