x86/microcode: Make sure boot_cpu_data.microcode is up-to-date
When preparing an MCE record for logging, boot_cpu_data.microcode is used
to read out the microcode revision on the box.
However, on systems where late microcode update has happened, the microcode
revision output in a MCE log record is wrong because
boot_cpu_data.microcode is not updated when the microcode gets updated.
But, the microcode revision saved in boot_cpu_data's microcode member
should be kept up-to-date, regardless, for consistency.
Make it so.
Fixes: fa94d0c6e0
("x86/MCE: Save microcode revision in machine check records")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: sironi@amazon.de
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180731112739.32338-1-prarit@redhat.com
This commit is contained in:
parent
ff924c5a1e
commit
370a132bb2
|
@ -537,6 +537,10 @@ static enum ucode_state apply_microcode_amd(int cpu)
|
||||||
uci->cpu_sig.rev = mc_amd->hdr.patch_id;
|
uci->cpu_sig.rev = mc_amd->hdr.patch_id;
|
||||||
c->microcode = mc_amd->hdr.patch_id;
|
c->microcode = mc_amd->hdr.patch_id;
|
||||||
|
|
||||||
|
/* Update boot_cpu_data's revision too, if we're on the BSP: */
|
||||||
|
if (c->cpu_index == boot_cpu_data.cpu_index)
|
||||||
|
boot_cpu_data.microcode = mc_amd->hdr.patch_id;
|
||||||
|
|
||||||
return UCODE_UPDATED;
|
return UCODE_UPDATED;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -851,6 +851,10 @@ static enum ucode_state apply_microcode_intel(int cpu)
|
||||||
uci->cpu_sig.rev = rev;
|
uci->cpu_sig.rev = rev;
|
||||||
c->microcode = rev;
|
c->microcode = rev;
|
||||||
|
|
||||||
|
/* Update boot_cpu_data's revision too, if we're on the BSP: */
|
||||||
|
if (c->cpu_index == boot_cpu_data.cpu_index)
|
||||||
|
boot_cpu_data.microcode = rev;
|
||||||
|
|
||||||
return UCODE_UPDATED;
|
return UCODE_UPDATED;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue