UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

coresight tmc etr: Make memory check consistent in the same function 

While operating from sysFS the TMC-ETR driver needs to make sure it has
memory to work with but doesn't allocate memory uselessly either.  Since
the main memory handle for this driver is drvdata::vaddr, use it throughout
function tmc_enable_etr_sink_sysfs() so that things are consistent.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mathieu Poirier 2018-05-09 12:06:05 -06:00 committed by Greg Kroah-Hartman
parent ad0dfdfd87
commit 3606a1dcb4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwtracing/coresight/coresight-tmc-etr.c
View File

@ -153,11 +153,11 @@ static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev)
goto out; goto out;
/* /*
* If drvdata::buf == NULL, use the memory allocated above. * If drvdata::vaddr == NULL, use the memory allocated above.
* Otherwise a buffer still exists from a previous session, so * Otherwise a buffer still exists from a previous session, so
* simply use that. * simply use that.
*/ */
if (drvdata->buf == NULL) { if (drvdata->vaddr == NULL) {
used = true; used = true;
drvdata->vaddr = vaddr; drvdata->vaddr = vaddr;
drvdata->paddr = paddr; drvdata->paddr = paddr;