ASoC: intel: skl-pcm: remove snd_pcm_ops
snd_pcm_ops is no longer needed. Let's use component driver callback. *Note* Only Intel skl-pcm has .get_time_info implementation, but ALSA SoC framework doesn't call it so far. To keep its implementation, this patch keeps .get_time_info, but it is still not called. Intel guy need to support it in the future. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87o8yzaf2f.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
86c05f3446
commit
3507bb5fe4
|
@ -1081,7 +1081,8 @@ int skl_dai_load(struct snd_soc_component *cmp, int index,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int skl_platform_open(struct snd_pcm_substream *substream)
|
||||
static int skl_platform_soc_open(struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream)
|
||||
{
|
||||
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
||||
struct snd_soc_dai_link *dai_link = rtd->dai_link;
|
||||
|
@ -1167,8 +1168,9 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int skl_platform_pcm_trigger(struct snd_pcm_substream *substream,
|
||||
int cmd)
|
||||
static int skl_platform_soc_trigger(struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream,
|
||||
int cmd)
|
||||
{
|
||||
struct hdac_bus *bus = get_bus_ctx(substream);
|
||||
|
||||
|
@ -1178,8 +1180,9 @@ static int skl_platform_pcm_trigger(struct snd_pcm_substream *substream,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static snd_pcm_uframes_t skl_platform_pcm_pointer
|
||||
(struct snd_pcm_substream *substream)
|
||||
static snd_pcm_uframes_t skl_platform_soc_pointer(
|
||||
struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream)
|
||||
{
|
||||
struct hdac_ext_stream *hstream = get_hdac_ext_stream(substream);
|
||||
struct hdac_bus *bus = get_bus_ctx(substream);
|
||||
|
@ -1225,6 +1228,24 @@ static snd_pcm_uframes_t skl_platform_pcm_pointer
|
|||
return bytes_to_frames(substream->runtime, pos);
|
||||
}
|
||||
|
||||
static int skl_platform_soc_mmap(struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream,
|
||||
struct vm_area_struct *area)
|
||||
{
|
||||
return snd_pcm_lib_default_mmap(substream, area);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_SND_DMA_SGBUF
|
||||
static struct page *skl_platform_soc_page(struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream,
|
||||
unsigned long offset)
|
||||
{
|
||||
return snd_pcm_sgbuf_ops_page(substream, offset);
|
||||
}
|
||||
#else
|
||||
#define skl_platform_soc_page NULL
|
||||
#endif /* CONFIG_SND_DMA_SGBUF */
|
||||
|
||||
static u64 skl_adjust_codec_delay(struct snd_pcm_substream *substream,
|
||||
u64 nsec)
|
||||
{
|
||||
|
@ -1245,7 +1266,9 @@ static u64 skl_adjust_codec_delay(struct snd_pcm_substream *substream,
|
|||
return (nsec > codec_nsecs) ? nsec - codec_nsecs : 0;
|
||||
}
|
||||
|
||||
static int skl_get_time_info(struct snd_pcm_substream *substream,
|
||||
static int skl_platform_soc_get_time_info(
|
||||
struct snd_soc_component *component,
|
||||
struct snd_pcm_substream *substream,
|
||||
struct timespec *system_ts, struct timespec *audio_ts,
|
||||
struct snd_pcm_audio_tstamp_config *audio_tstamp_config,
|
||||
struct snd_pcm_audio_tstamp_report *audio_tstamp_report)
|
||||
|
@ -1277,24 +1300,16 @@ static int skl_get_time_info(struct snd_pcm_substream *substream,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static const struct snd_pcm_ops skl_platform_ops = {
|
||||
.open = skl_platform_open,
|
||||
.ioctl = snd_pcm_lib_ioctl,
|
||||
.trigger = skl_platform_pcm_trigger,
|
||||
.pointer = skl_platform_pcm_pointer,
|
||||
.get_time_info = skl_get_time_info,
|
||||
.mmap = snd_pcm_lib_default_mmap,
|
||||
.page = snd_pcm_sgbuf_ops_page,
|
||||
};
|
||||
|
||||
static void skl_pcm_free(struct snd_pcm *pcm)
|
||||
static void skl_platform_soc_free(struct snd_soc_component *component,
|
||||
struct snd_pcm *pcm)
|
||||
{
|
||||
snd_pcm_lib_preallocate_free_for_all(pcm);
|
||||
}
|
||||
|
||||
#define MAX_PREALLOC_SIZE (32 * 1024 * 1024)
|
||||
|
||||
static int skl_pcm_new(struct snd_soc_pcm_runtime *rtd)
|
||||
static int skl_platform_soc_new(struct snd_soc_component *component,
|
||||
struct snd_soc_pcm_runtime *rtd)
|
||||
{
|
||||
struct snd_soc_dai *dai = rtd->cpu_dai;
|
||||
struct hdac_bus *bus = dev_get_drvdata(dai->dev);
|
||||
|
@ -1458,7 +1473,7 @@ static int skl_platform_soc_probe(struct snd_soc_component *component)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static void skl_pcm_remove(struct snd_soc_component *component)
|
||||
static void skl_platform_soc_remove(struct snd_soc_component *component)
|
||||
{
|
||||
struct hdac_bus *bus = dev_get_drvdata(component->dev);
|
||||
struct skl_dev *skl = bus_to_skl(bus);
|
||||
|
@ -1471,10 +1486,16 @@ static void skl_pcm_remove(struct snd_soc_component *component)
|
|||
static const struct snd_soc_component_driver skl_component = {
|
||||
.name = "pcm",
|
||||
.probe = skl_platform_soc_probe,
|
||||
.remove = skl_pcm_remove,
|
||||
.ops = &skl_platform_ops,
|
||||
.pcm_new = skl_pcm_new,
|
||||
.pcm_free = skl_pcm_free,
|
||||
.remove = skl_platform_soc_remove,
|
||||
.open = skl_platform_soc_open,
|
||||
.ioctl = snd_soc_pcm_lib_ioctl,
|
||||
.trigger = skl_platform_soc_trigger,
|
||||
.pointer = skl_platform_soc_pointer,
|
||||
.get_time_info = skl_platform_soc_get_time_info,
|
||||
.mmap = skl_platform_soc_mmap,
|
||||
.page = skl_platform_soc_page,
|
||||
.pcm_construct = skl_platform_soc_new,
|
||||
.pcm_destruct = skl_platform_soc_free,
|
||||
.module_get_upon_open = 1, /* increment refcount when a pcm is opened */
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in New Issue