UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

rtla: Fix the help text in osnoise and timerlat top tools 

commit 3d7b8ea7a8a20a45d019382c4dc6ed79e8bb95cf upstream.

The help text in osnoise top and timerlat top had some minor errors
and omissions. The -d option was missing the 's' (second) abbreviation and
the error message for '-d' used '-D'.

Cc: stable@vger.kernel.org
Fixes: 1eceb2fc2c ("rtla/osnoise: Add osnoise top mode")
Fixes: a828cd18bc ("rtla: Add timerlat tool and timelart top mode")
Link: https://lore.kernel.org/20240813155831.384446-1-ezulian@redhat.com
Suggested-by: Tomas Glozar <tglozar@redhat.com>
Reviewed-by: Tomas Glozar <tglozar@redhat.com>
Signed-off-by: Eder Zulian <ezulian@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Eder Zulian 2024-08-13 17:58:31 +02:00 committed by Greg Kroah-Hartman
parent 8b0f0a268d
commit 310d953167
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/tracing/rtla/src/osnoise_top.c
View File

@ -428,7 +428,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
case 'd': case 'd':
params->duration = parse_seconds_duration(optarg); params->duration = parse_seconds_duration(optarg);
if (!params->duration) if (!params->duration)
osnoise_top_usage(params, "Invalid -D duration\n"); osnoise_top_usage(params, "Invalid -d duration\n");
break; break;
case 'e': case 'e':
tevent = trace_event_alloc(optarg); tevent = trace_event_alloc(optarg);

4
tools/tracing/rtla/src/timerlat_top.c
View File

@ -339,7 +339,7 @@ static void timerlat_top_usage(char *usage)
" -c/--cpus cpus: run the tracer only on the given cpus", " -c/--cpus cpus: run the tracer only on the given cpus",
" -H/--house-keeping cpus: run rtla control threads only on the given cpus", " -H/--house-keeping cpus: run rtla control threads only on the given cpus",
" -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited", " -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",
" -d/--duration time[m|h|d]: duration of the session in seconds", " -d/--duration time[s|m|h|d]: duration of the session",
" -D/--debug: print debug info", " -D/--debug: print debug info",
" --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)", " --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",
" -t/--trace[=file]: save the stopped trace to [file|timerlat_trace.txt]", " -t/--trace[=file]: save the stopped trace to [file|timerlat_trace.txt]",
@ -485,7 +485,7 @@ static struct timerlat_top_params
case 'd': case 'd':
params->duration = parse_seconds_duration(optarg); params->duration = parse_seconds_duration(optarg);
if (!params->duration) if (!params->duration)
timerlat_top_usage("Invalid -D duration\n"); timerlat_top_usage("Invalid -d duration\n");
break; break;
case 'e': case 'e':
tevent = trace_event_alloc(optarg); tevent = trace_event_alloc(optarg);