RDMA/rxe: Simplify the error handling code in rxe_create_ah()

This patch not only simplifies the error handling code in rxe_create_ah()
but also removes the dead code that was left behind by commit 47ec386662
("RDMA: Convert drivers to use sgid_attr instead of sgid_index").

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Bart Van Assche 2018-07-06 09:45:32 -07:00 committed by Jason Gunthorpe
parent efdbda81d9
commit 2f229bcf25
1 changed files with 3 additions and 10 deletions

View File

@ -241,24 +241,17 @@ static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd,
err = rxe_av_chk_attr(rxe, attr); err = rxe_av_chk_attr(rxe, attr);
if (err) if (err)
goto err1; return ERR_PTR(err);
ah = rxe_alloc(&rxe->ah_pool); ah = rxe_alloc(&rxe->ah_pool);
if (!ah) { if (!ah)
err = -ENOMEM; return ERR_PTR(-ENOMEM);
goto err1;
}
rxe_add_ref(pd); rxe_add_ref(pd);
ah->pd = pd; ah->pd = pd;
rxe_init_av(rxe, attr, &ah->av); rxe_init_av(rxe, attr, &ah->av);
return &ah->ibah; return &ah->ibah;
rxe_drop_ref(pd);
rxe_drop_ref(ah);
err1:
return ERR_PTR(err);
} }
static int rxe_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) static int rxe_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr)