UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

Staging: Correct use of ! and & 

Correct priority problem in the use of ! and &.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
- !E & C
+ !(E & C)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall 2009-07-27 21:59:48 +02:00 committed by Greg Kroah-Hartman
parent 658ce9d653
commit 2e9ab1e72c
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rt3090/sta_ioctl.c
View File

@ -1840,11 +1840,9 @@ int rt_ioctl_siwencode(struct net_device *dev,
} }
else else
/* Don't complain if only change the mode */ /* Don't complain if only change the mode */
if(!erq->flags & IW_ENCODE_MODE) if (!(erq->flags & IW_ENCODE_MODE))
{
return -EINVAL; return -EINVAL;
} }
}
done: done:
DBGPRINT(RT_DEBUG_TRACE ,("==>rt_ioctl_siwencode::erq->flags=%x\n",erq->flags)); DBGPRINT(RT_DEBUG_TRACE ,("==>rt_ioctl_siwencode::erq->flags=%x\n",erq->flags));

3
drivers/staging/vt6656/iwctl.c
View File

@ -1409,8 +1409,7 @@ int iwctl_siwencode(struct net_device *dev,
// Do we want to just set the transmit key index ? // Do we want to just set the transmit key index ?
if ( index < 4 ) { if ( index < 4 ) {
pDevice->byKeyIndex = index; pDevice->byKeyIndex = index;
} } else if (!(wrq->flags & IW_ENCODE_MODE)) {
else if(!wrq->flags & IW_ENCODE_MODE) {
rc = -EINVAL; rc = -EINVAL;
return rc; return rc;
} }