com20020_cs: Remove typedef com20020_dev_t
The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for com20020_dev_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
f865346407
commit
2dfd2533e9
|
@ -112,20 +112,20 @@ static void com20020_detach(struct pcmcia_device *p_dev);
|
||||||
|
|
||||||
/*====================================================================*/
|
/*====================================================================*/
|
||||||
|
|
||||||
typedef struct com20020_dev_t {
|
struct com20020_dev {
|
||||||
struct net_device *dev;
|
struct net_device *dev;
|
||||||
} com20020_dev_t;
|
};
|
||||||
|
|
||||||
static int com20020_probe(struct pcmcia_device *p_dev)
|
static int com20020_probe(struct pcmcia_device *p_dev)
|
||||||
{
|
{
|
||||||
com20020_dev_t *info;
|
struct com20020_dev *info;
|
||||||
struct net_device *dev;
|
struct net_device *dev;
|
||||||
struct arcnet_local *lp;
|
struct arcnet_local *lp;
|
||||||
|
|
||||||
dev_dbg(&p_dev->dev, "com20020_attach()\n");
|
dev_dbg(&p_dev->dev, "com20020_attach()\n");
|
||||||
|
|
||||||
/* Create new network device */
|
/* Create new network device */
|
||||||
info = kzalloc(sizeof(struct com20020_dev_t), GFP_KERNEL);
|
info = kzalloc(sizeof(*info), GFP_KERNEL);
|
||||||
if (!info)
|
if (!info)
|
||||||
goto fail_alloc_info;
|
goto fail_alloc_info;
|
||||||
|
|
||||||
|
@ -160,7 +160,7 @@ fail_alloc_info:
|
||||||
|
|
||||||
static void com20020_detach(struct pcmcia_device *link)
|
static void com20020_detach(struct pcmcia_device *link)
|
||||||
{
|
{
|
||||||
struct com20020_dev_t *info = link->priv;
|
struct com20020_dev *info = link->priv;
|
||||||
struct net_device *dev = info->dev;
|
struct net_device *dev = info->dev;
|
||||||
|
|
||||||
dev_dbg(&link->dev, "detach...\n");
|
dev_dbg(&link->dev, "detach...\n");
|
||||||
|
@ -199,7 +199,7 @@ static void com20020_detach(struct pcmcia_device *link)
|
||||||
static int com20020_config(struct pcmcia_device *link)
|
static int com20020_config(struct pcmcia_device *link)
|
||||||
{
|
{
|
||||||
struct arcnet_local *lp;
|
struct arcnet_local *lp;
|
||||||
com20020_dev_t *info;
|
struct com20020_dev *info;
|
||||||
struct net_device *dev;
|
struct net_device *dev;
|
||||||
int i, ret;
|
int i, ret;
|
||||||
int ioaddr;
|
int ioaddr;
|
||||||
|
@ -291,7 +291,7 @@ static void com20020_release(struct pcmcia_device *link)
|
||||||
|
|
||||||
static int com20020_suspend(struct pcmcia_device *link)
|
static int com20020_suspend(struct pcmcia_device *link)
|
||||||
{
|
{
|
||||||
com20020_dev_t *info = link->priv;
|
struct com20020_dev *info = link->priv;
|
||||||
struct net_device *dev = info->dev;
|
struct net_device *dev = info->dev;
|
||||||
|
|
||||||
if (link->open)
|
if (link->open)
|
||||||
|
@ -302,7 +302,7 @@ static int com20020_suspend(struct pcmcia_device *link)
|
||||||
|
|
||||||
static int com20020_resume(struct pcmcia_device *link)
|
static int com20020_resume(struct pcmcia_device *link)
|
||||||
{
|
{
|
||||||
com20020_dev_t *info = link->priv;
|
struct com20020_dev *info = link->priv;
|
||||||
struct net_device *dev = info->dev;
|
struct net_device *dev = info->dev;
|
||||||
|
|
||||||
if (link->open) {
|
if (link->open) {
|
||||||
|
|
Loading…
Reference in New Issue