UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

devcgroup: use kmemdup() 

This saves 40 bytes on my x86_32 box.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Paul Menage <menage@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Li Zefan 2008-10-18 20:28:06 -07:00 committed by Linus Torvalds
parent 886465f407
commit 2cdc7241a2
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
security/device_cgroup.c
View File

@ -84,13 +84,9 @@ static int dev_whitelist_copy(struct list_head *dest, struct list_head *orig)
struct dev_whitelist_item *wh, *tmp, *new; struct dev_whitelist_item *wh, *tmp, *new;
list_for_each_entry(wh, orig, list) { list_for_each_entry(wh, orig, list) {
new = kmalloc(sizeof(*wh), GFP_KERNEL); new = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
if (!new) if (!new)
goto free_and_exit; goto free_and_exit;
new->major = wh->major;
new->minor = wh->minor;
new->type = wh->type;
new->access = wh->access;
list_add_tail(&new->list, dest); list_add_tail(&new->list, dest);
} }
@ -114,11 +110,10 @@ static int dev_whitelist_add(struct dev_cgroup *dev_cgroup,
{ {
struct dev_whitelist_item *whcopy, *walk; struct dev_whitelist_item *whcopy, *walk;
whcopy = kmalloc(sizeof(*whcopy), GFP_KERNEL); whcopy = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
if (!whcopy) if (!whcopy)
return -ENOMEM; return -ENOMEM;
memcpy(whcopy, wh, sizeof(*whcopy));
spin_lock(&dev_cgroup->lock); spin_lock(&dev_cgroup->lock);
list_for_each_entry(walk, &dev_cgroup->whitelist, list) { list_for_each_entry(walk, &dev_cgroup->whitelist, list) {
if (walk->type != wh->type) if (walk->type != wh->type)