UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

usb: phy: ab8500-usb: Pass the IRQF_ONESHOT flag 

Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Fabio Estevam 2015-05-22 23:28:15 -03:00 committed by Felipe Balbi
parent 7cc99f1e9a
commit 2b12978928
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/phy/phy-ab8500-usb.c
View File

@ -1179,7 +1179,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev,
} }
err = devm_request_threaded_irq(&pdev->dev, irq, NULL, err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
ab8500_usb_link_status_irq, ab8500_usb_link_status_irq,
IRQF_NO_SUSPEND | IRQF_SHARED, IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
"usb-link-status", ab); "usb-link-status", ab);
if (err < 0) { if (err < 0) {
dev_err(ab->dev, "request_irq failed for link status irq\n"); dev_err(ab->dev, "request_irq failed for link status irq\n");
@ -1195,7 +1195,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev,
} }
err = devm_request_threaded_irq(&pdev->dev, irq, NULL, err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
ab8500_usb_disconnect_irq, ab8500_usb_disconnect_irq,
IRQF_NO_SUSPEND | IRQF_SHARED, IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
"usb-id-fall", ab); "usb-id-fall", ab);
if (err < 0) { if (err < 0) {
dev_err(ab->dev, "request_irq failed for ID fall irq\n"); dev_err(ab->dev, "request_irq failed for ID fall irq\n");
@ -1211,7 +1211,7 @@ static int ab8500_usb_irq_setup(struct platform_device *pdev,
} }
err = devm_request_threaded_irq(&pdev->dev, irq, NULL, err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
ab8500_usb_disconnect_irq, ab8500_usb_disconnect_irq,
IRQF_NO_SUSPEND | IRQF_SHARED, IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
"usb-vbus-fall", ab); "usb-vbus-fall", ab);
if (err < 0) { if (err < 0) {
dev_err(ab->dev, "request_irq failed for Vbus fall irq\n"); dev_err(ab->dev, "request_irq failed for Vbus fall irq\n");