uacce: vma_close clears q->qfrs when freeing qfrs

vma_close frees qfrs but not clears q->qfrs, which still points
to the freed object, leading to subsequent mmap fail.
So vma_close clears q->qfrs as well.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Link: https://lore.kernel.org/r/20230511095921.9331-3-zhangfei.gao@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zhangfei Gao 2023-05-11 17:59:21 +08:00 committed by Greg Kroah-Hartman
parent df1b056d48
commit 282c22a8bb
1 changed files with 7 additions and 4 deletions

View File

@ -200,12 +200,15 @@ static int uacce_fops_release(struct inode *inode, struct file *filep)
static void uacce_vma_close(struct vm_area_struct *vma)
{
struct uacce_queue *q = vma->vm_private_data;
struct uacce_qfile_region *qfr = NULL;
if (vma->vm_pgoff < UACCE_MAX_REGION)
qfr = q->qfrs[vma->vm_pgoff];
if (vma->vm_pgoff < UACCE_MAX_REGION) {
struct uacce_qfile_region *qfr = q->qfrs[vma->vm_pgoff];
kfree(qfr);
mutex_lock(&q->mutex);
q->qfrs[vma->vm_pgoff] = NULL;
mutex_unlock(&q->mutex);
kfree(qfr);
}
}
static const struct vm_operations_struct uacce_vm_ops = {