UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

MIPS: generic/yamon-dt: fix uninitialized variable error 

In the case where fw_getenv returns an error when fetching values
for ememsizea and memsize then variable phys_memsize is not assigned
a variable and will be uninitialized on a zero check of phys_memsize.
Fix this by initializing phys_memsize to zero.

Cleans up cppcheck error:
arch/mips/generic/yamon-dt.c💯7: error: Uninitialized variable: phys_memsize [uninitvar]

Fixes: f41d2430bb ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
Colin Ian King 2021-11-10 23:28:24 +00:00 committed by Thomas Bogendoerfer
parent b3ff2881ba
commit 255e51da15
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/mips/generic/yamon-dt.c
View File

@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array(
__init int yamon_dt_append_memory(void *fdt, __init int yamon_dt_append_memory(void *fdt,
const struct yamon_mem_region *regions) const struct yamon_mem_region *regions)
{ {
unsigned long phys_memsize, memsize; unsigned long phys_memsize = 0, memsize;
__be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES]; __be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];
unsigned int mem_entries; unsigned int mem_entries;
int i, err, mem_off; int i, err, mem_off;