UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

hfsplus: fix BKL leak in hfsplus_ioctl 

Currenly the HFSPLUS_IOC_EXT2_GETFLAGS case never unlocks the BKL, which
can lead to easily reproduced lockups when doing multiple GETFLAGS ioctls.

Fix this by only taking the BKL for the HFSPLUS_IOC_EXT2_SETFLAGS case
as neither HFSPLUS_IOC_EXT2_GETFLAGS not the default error case needs it.

Signed-off-by: Christoph Hellwig <hch@tuxera.com>
This commit is contained in:
Christoph Hellwig 2010-10-01 05:41:27 +02:00
parent 0f44fbd297
commit 249e635300
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/hfsplus/ioctl.c
View File

@ -26,7 +26,6 @@ long hfsplus_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
struct inode *inode = filp->f_path.dentry->d_inode; struct inode *inode = filp->f_path.dentry->d_inode;
unsigned int flags; unsigned int flags;
lock_kernel();
switch (cmd) { switch (cmd) {
case HFSPLUS_IOC_EXT2_GETFLAGS: case HFSPLUS_IOC_EXT2_GETFLAGS:
flags = 0; flags = 0;
@ -39,6 +38,8 @@ long hfsplus_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
return put_user(flags, (int __user *)arg); return put_user(flags, (int __user *)arg);
case HFSPLUS_IOC_EXT2_SETFLAGS: { case HFSPLUS_IOC_EXT2_SETFLAGS: {
int err = 0; int err = 0;
lock_kernel();
err = mnt_want_write(filp->f_path.mnt); err = mnt_want_write(filp->f_path.mnt);
if (err) { if (err) {
unlock_kernel(); unlock_kernel();
@ -93,7 +94,6 @@ setflags_out:
return err; return err;
} }
default: default:
unlock_kernel();
return -ENOTTY; return -ENOTTY;
} }
} }