UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: rtl8188eu: fix double unlock error in rtw_resume_process() 

Fix following static checker warning:
    drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process()
    error: double unlock 'mutex:&pwrpriv->mutex_lock'

Fixes: eaf47b713b ("staging: rtl8188eu: fix missing unlock on error in rtw_resume_process()")
Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2016-10-01 00:38:08 +08:00 committed by Greg Kroah-Hartman
parent 612e1c94bf
commit 23bf40424a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/rtl8188eu/os_dep/usb_intf.c
View File

@ -294,8 +294,10 @@ static int rtw_resume_process(struct adapter *padapter)
pwrpriv->bkeepfwalive = false; pwrpriv->bkeepfwalive = false;
pr_debug("bkeepfwalive(%x)\n", pwrpriv->bkeepfwalive); pr_debug("bkeepfwalive(%x)\n", pwrpriv->bkeepfwalive);
if (pm_netdev_open(pnetdev, true) != 0) if (pm_netdev_open(pnetdev, true) != 0) {
mutex_unlock(&pwrpriv->mutex_lock);
goto exit; goto exit;
}
netif_device_attach(pnetdev); netif_device_attach(pnetdev);
netif_carrier_on(pnetdev); netif_carrier_on(pnetdev);
@ -306,10 +308,8 @@ static int rtw_resume_process(struct adapter *padapter)
ret = 0; ret = 0;
exit: exit:
if (pwrpriv) { if (pwrpriv)
pwrpriv->bInSuspend = false; pwrpriv->bInSuspend = false;
mutex_unlock(&pwrpriv->mutex_lock);
}
pr_debug("<=== %s return %d.............. in %dms\n", __func__, pr_debug("<=== %s return %d.............. in %dms\n", __func__,
ret, jiffies_to_msecs(jiffies - start_time)); ret, jiffies_to_msecs(jiffies - start_time));