ceph: use frag's MDS in either mode
When doing some tests with multiple mds, we were seeing many mds forwarding requests between them, causing clients to resend. If the request is a modification operation and the mode is set to USE_AUTH_MDS, then the auth mds should be selected to handle the request. If auth mds for frag is already set, then it should be returned directly without further processing. The current logic is wrong because it only returns directly if mode is USE_AUTH_MDS, but we want to do that for all modes. If we don't, then when the frag's mds is not equal to cap session's mds, the request will get sent to the wrong MDS needlessly. Drop the mode check in this condition. Signed-off-by: Yanhu Cao <gmayyyha@gmail.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
parent
a0102bda5b
commit
224c7b6778
|
@ -1103,8 +1103,7 @@ static int __choose_mds(struct ceph_mds_client *mdsc,
|
|||
frag.frag, mds);
|
||||
if (ceph_mdsmap_get_state(mdsc->mdsmap, mds) >=
|
||||
CEPH_MDS_STATE_ACTIVE) {
|
||||
if (mode == USE_ANY_MDS &&
|
||||
!ceph_mdsmap_is_laggy(mdsc->mdsmap,
|
||||
if (!ceph_mdsmap_is_laggy(mdsc->mdsmap,
|
||||
mds))
|
||||
goto out;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue