UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

mtd: rawnand: Avoid indirect access to ->data_buf() 

The logic in nand_do_read_ops() is to use a bufpoi variable, either
set to the original buffer, or set to a bounce buffer which in the end
happens to be chip->data_buf depending on the value of the
use_bounce_buf boolean. This is not a reason to call chip->data_buf
directly when we know that we are using the bounce buffer. Let's use
bufpoi instead to be consistent.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-mtd/20200507105241.14299-7-miquel.raynal@bootlin.com
This commit is contained in:
Miquel Raynal 2020-05-07 12:52:34 +02:00
parent 6446907307
commit 21b5cf3f64
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mtd/nand/raw/nand_base.c
View File

@ -3293,7 +3293,7 @@ read_retry:
/* Invalidate page cache */ /* Invalidate page cache */
chip->pagecache.page = -1; chip->pagecache.page = -1;
} }
memcpy(buf, chip->data_buf + col, bytes); memcpy(buf, bufpoi + col, bytes);
} }
if (unlikely(oob)) { if (unlikely(oob)) {