intel_scu_ipcutil: fix major device number handling
We need to save major device number to be able to use it for unregister_chrdev() in ipc_module_exit(). ipc_module_init() must return 0 on success, not major device number. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
parent
6cb8c13da1
commit
21893ab24c
|
@ -24,7 +24,7 @@
|
||||||
#include <linux/init.h>
|
#include <linux/init.h>
|
||||||
#include <asm/intel_scu_ipc.h>
|
#include <asm/intel_scu_ipc.h>
|
||||||
|
|
||||||
static u32 major;
|
static int major;
|
||||||
|
|
||||||
#define MAX_FW_SIZE 264192
|
#define MAX_FW_SIZE 264192
|
||||||
|
|
||||||
|
@ -117,7 +117,11 @@ static const struct file_operations scu_ipc_fops = {
|
||||||
|
|
||||||
static int __init ipc_module_init(void)
|
static int __init ipc_module_init(void)
|
||||||
{
|
{
|
||||||
return register_chrdev(0, "intel_mid_scu", &scu_ipc_fops);
|
major = register_chrdev(0, "intel_mid_scu", &scu_ipc_fops);
|
||||||
|
if (major < 0)
|
||||||
|
return major;
|
||||||
|
|
||||||
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static void __exit ipc_module_exit(void)
|
static void __exit ipc_module_exit(void)
|
||||||
|
|
Loading…
Reference in New Issue