From 2170dd04316e0754cbbfa4892a25aead39d225f7 Mon Sep 17 00:00:00 2001 From: Alexey Kardashevskiy Date: Thu, 7 Dec 2017 12:56:54 +1100 Subject: [PATCH] vfio-pci: Mask INTx if a device is not capabable of enabling it At the moment VFIO rightfully assumes that INTx is supported if the interrupt pin is not set to zero in the device config space. However if that is not the case (the pin is not zero but pdev->irq is), vfio_intx_enable() fails. In order to prevent the userspace from trying to enable INTx when we know that it cannot work, let's mask the PCI_INTERRUPT_PIN register. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index f041b1a6cf66..a98681dca1d3 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -207,6 +207,9 @@ static bool vfio_pci_nointx(struct pci_dev *pdev) } } + if (!pdev->irq) + return true; + return false; }