UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

mtd: require write permissions for locking and badblock ioctls 

MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require
write permission. Depending on the hardware MEMLOCK might even be
write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK
is always write-once.

MEMSETBADBLOCK modifies the bad block table.

Fixes: f7e6b19bc7 ("mtd: properly check all write ioctls for permissions")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210303155735.25887-1-michael@walle.cc
This commit is contained in:
Michael Walle 2021-03-03 16:57:35 +01:00 committed by Miquel Raynal
parent 3ba6d1ff04
commit 1e97743fd1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mtd/mtdchar.c
View File

@ -643,16 +643,12 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
case MEMGETINFO: case MEMGETINFO:
case MEMREADOOB: case MEMREADOOB:
case MEMREADOOB64: case MEMREADOOB64:
case MEMLOCK:
case MEMUNLOCK:
case MEMISLOCKED: case MEMISLOCKED:
case MEMGETOOBSEL: case MEMGETOOBSEL:
case MEMGETBADBLOCK: case MEMGETBADBLOCK:
case MEMSETBADBLOCK:
case OTPSELECT: case OTPSELECT:
case OTPGETREGIONCOUNT: case OTPGETREGIONCOUNT:
case OTPGETREGIONINFO: case OTPGETREGIONINFO:
case OTPLOCK:
case ECCGETLAYOUT: case ECCGETLAYOUT:
case ECCGETSTATS: case ECCGETSTATS:
case MTDFILEMODE: case MTDFILEMODE:
@ -663,9 +659,13 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
/* "dangerous" commands */ /* "dangerous" commands */
case MEMERASE: case MEMERASE:
case MEMERASE64: case MEMERASE64:
case MEMLOCK:
case MEMUNLOCK:
case MEMSETBADBLOCK:
case MEMWRITEOOB: case MEMWRITEOOB:
case MEMWRITEOOB64: case MEMWRITEOOB64:
case MEMWRITE: case MEMWRITE:
case OTPLOCK:
if (!(file->f_mode & FMODE_WRITE)) if (!(file->f_mode & FMODE_WRITE))
return -EPERM; return -EPERM;
break; break;