drivers/net/wireless/orinoco: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
27b81bbed8
commit
1d66fa777d
|
@ -993,11 +993,9 @@ static int orinoco_ioctl_set_genie(struct net_device *dev,
|
|||
return -EINVAL;
|
||||
|
||||
if (wrqu->data.length) {
|
||||
buf = kmalloc(wrqu->data.length, GFP_KERNEL);
|
||||
buf = kmemdup(extra, wrqu->data.length, GFP_KERNEL);
|
||||
if (buf == NULL)
|
||||
return -ENOMEM;
|
||||
|
||||
memcpy(buf, extra, wrqu->data.length);
|
||||
} else
|
||||
buf = NULL;
|
||||
|
||||
|
|
Loading…
Reference in New Issue