UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: target: tcmu: Allocate zeroed pages for data area 

Tcmu populates the data area (used for communication with userspace) with
pages that are allocated by calling alloc_page(GFP_NOIO).  Therefore
previous content of the allocated pages is exposed to user space. Avoid
this by adding __GFP_ZERO flag.

Zeroing the pages does (nearly) not affect tcmu throughput, because
allocated pages are re-used for the data transfers of later SCSI cmds.

Link: https://lore.kernel.org/r/20211013171606.25197-1-bostroesser@gmail.com
Signed-off-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bodo Stroesser 2021-10-13 19:16:06 +02:00 committed by Martin K. Petersen
parent d1e51ea6bf
commit 1d2ac7b69d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/target/target_core_user.c
View File

@ -523,8 +523,8 @@ static inline int tcmu_get_empty_block(struct tcmu_dev *udev,
rcu_read_unlock(); rcu_read_unlock();
for (i = cnt; i < page_cnt; i++) { for (i = cnt; i < page_cnt; i++) {
/* try to get new page from the mm */ /* try to get new zeroed page from the mm */
page = alloc_page(GFP_NOIO); page = alloc_page(GFP_NOIO | __GFP_ZERO);
if (!page) if (!page)
break; break;