media: xilinx: vipp: Fix refcount leak in xvip_graph_dma_init
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: df3305156f
("[media] v4l: xilinx: Add Xilinx Video IP core")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
parent
d6a1feba5d
commit
1c78f19c3a
|
@ -471,7 +471,7 @@ static int xvip_graph_dma_init(struct xvip_composite_device *xdev)
|
|||
{
|
||||
struct device_node *ports;
|
||||
struct device_node *port;
|
||||
int ret;
|
||||
int ret = 0;
|
||||
|
||||
ports = of_get_child_by_name(xdev->dev->of_node, "ports");
|
||||
if (ports == NULL) {
|
||||
|
@ -481,13 +481,14 @@ static int xvip_graph_dma_init(struct xvip_composite_device *xdev)
|
|||
|
||||
for_each_child_of_node(ports, port) {
|
||||
ret = xvip_graph_dma_init_one(xdev, port);
|
||||
if (ret < 0) {
|
||||
if (ret) {
|
||||
of_node_put(port);
|
||||
return ret;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
return 0;
|
||||
of_node_put(ports);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static void xvip_graph_cleanup(struct xvip_composite_device *xdev)
|
||||
|
|
Loading…
Reference in New Issue