UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

rtl8180: fix enabled interrupt mask for rtl8187se 

When preparing the bitfield to write to HW register, the high-priority
queue error interrupt bit is set two times, and the beacon queue
TX-OK interrupt is not enabled.

Currently this have no functional impact because the high-priority
queue is not used at all, and the beacon queue is not used yet.

This patch removes high-priority queue bits and it adds the
beacon queue missing bit.
It removes also the management queue bits because it is not used.

This was found by static code analyzer.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Andrea Merello 2014-04-04 18:21:14 +02:00 committed by John W. Linville
parent 222aaffe12
commit 1c3fb9b8f8
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/rtl818x/rtl8180/dev.c
View File

@ -683,9 +683,8 @@ static void rtl8180_int_enable(struct ieee80211_hw *dev)
struct rtl8180_priv *priv = dev->priv; struct rtl8180_priv *priv = dev->priv;
if (priv->chip_family == RTL818X_CHIP_FAMILY_RTL8187SE) { if (priv->chip_family == RTL818X_CHIP_FAMILY_RTL8187SE) {
rtl818x_iowrite32(priv, &priv->map->IMR, IMR_TMGDOK | rtl818x_iowrite32(priv, &priv->map->IMR,
IMR_TBDER | IMR_THPDER | IMR_TBDER | IMR_TBDOK |
IMR_THPDER | IMR_THPDOK |
IMR_TVODER | IMR_TVODOK | IMR_TVODER | IMR_TVODOK |
IMR_TVIDER | IMR_TVIDOK | IMR_TVIDER | IMR_TVIDOK |
IMR_TBEDER | IMR_TBEDOK | IMR_TBEDER | IMR_TBEDOK |