rbd: convert all rbd_assert(0) to BUG()
rbd_assert(0) has caused different issues depending on the compiler version in the past, so it seems better to avoid it completely. Replace the remaining instances. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
parent
d342a15b1e
commit
1680937266
|
@ -1326,7 +1326,7 @@ static void rbd_obj_zero_range(struct rbd_obj_request *obj_req, u32 off,
|
||||||
zero_bvecs(&obj_req->bvec_pos, off, bytes);
|
zero_bvecs(&obj_req->bvec_pos, off, bytes);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1581,7 +1581,7 @@ static void rbd_obj_request_destroy(struct kref *kref)
|
||||||
kfree(obj_request->bvec_pos.bvecs);
|
kfree(obj_request->bvec_pos.bvecs);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
|
|
||||||
kfree(obj_request->img_extents);
|
kfree(obj_request->img_extents);
|
||||||
|
@ -1781,7 +1781,7 @@ static void rbd_osd_req_setup_data(struct rbd_obj_request *obj_req, u32 which)
|
||||||
&obj_req->bvec_pos);
|
&obj_req->bvec_pos);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2036,7 +2036,7 @@ static int __rbd_img_fill_request(struct rbd_img_request *img_req)
|
||||||
ret = rbd_obj_setup_zeroout(obj_req);
|
ret = rbd_obj_setup_zeroout(obj_req);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
@ -2515,7 +2515,7 @@ static int rbd_obj_issue_copyup_ops(struct rbd_obj_request *obj_req, u32 bytes)
|
||||||
num_osd_ops += count_zeroout_ops(obj_req);
|
num_osd_ops += count_zeroout_ops(obj_req);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
|
|
||||||
obj_req->osd_req = rbd_osd_req_create(obj_req, num_osd_ops);
|
obj_req->osd_req = rbd_osd_req_create(obj_req, num_osd_ops);
|
||||||
|
@ -2542,7 +2542,7 @@ static int rbd_obj_issue_copyup_ops(struct rbd_obj_request *obj_req, u32 bytes)
|
||||||
__rbd_obj_setup_zeroout(obj_req, which);
|
__rbd_obj_setup_zeroout(obj_req, which);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rbd_assert(0);
|
BUG();
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = ceph_osdc_alloc_messages(obj_req->osd_req, GFP_NOIO);
|
ret = ceph_osdc_alloc_messages(obj_req->osd_req, GFP_NOIO);
|
||||||
|
|
Loading…
Reference in New Issue