UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

hwmon: (hih6130) Use permission specific SENSOR[_DEVICE]_ATTR variants 

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.

Also replace any remaining S_<PERMS> in the driver with octal values.

The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/.

This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2018-12-10 14:02:08 -08:00
parent 905bc0d460
commit 1640bb596e
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/hwmon/hih6130.c
View File

@ -171,7 +171,7 @@ out:
* Will be called on read access to temp1_input sysfs attribute. * Will be called on read access to temp1_input sysfs attribute.
* Returns number of bytes written into buffer, negative errno on error. * Returns number of bytes written into buffer, negative errno on error.
*/ */
static ssize_t hih6130_show_temperature(struct device *dev, static ssize_t hih6130_temperature_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
@ -193,7 +193,7 @@ static ssize_t hih6130_show_temperature(struct device *dev,
* Will be called on read access to humidity1_input sysfs attribute. * Will be called on read access to humidity1_input sysfs attribute.
* Returns number of bytes written into buffer, negative errno on error. * Returns number of bytes written into buffer, negative errno on error.
*/ */
static ssize_t hih6130_show_humidity(struct device *dev, static ssize_t hih6130_humidity_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct hih6130 *hih6130 = dev_get_drvdata(dev); struct hih6130 *hih6130 = dev_get_drvdata(dev);
@ -206,10 +206,8 @@ static ssize_t hih6130_show_humidity(struct device *dev,
} }
/* sysfs attributes */ /* sysfs attributes */
static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, hih6130_show_temperature, static SENSOR_DEVICE_ATTR_RO(temp1_input, hih6130_temperature, 0);
NULL, 0); static SENSOR_DEVICE_ATTR_RO(humidity1_input, hih6130_humidity, 0);
static SENSOR_DEVICE_ATTR(humidity1_input, S_IRUGO, hih6130_show_humidity,
NULL, 0);
static struct attribute *hih6130_attrs[] = { static struct attribute *hih6130_attrs[] = {
&sensor_dev_attr_temp1_input.dev_attr.attr, &sensor_dev_attr_temp1_input.dev_attr.attr,