UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

platform/x86: amd-pmc: call dump registers only once 

Currently amd_pmc_dump_registers() routine is being called at
multiple places. The best to call it is after command submission
to SMU.

Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210629084803.248498-4-Shyam-sundar.S-k@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Shyam Sundar S K 2021-06-29 14:17:59 +05:30 committed by Hans de Goede
parent 4c06d35dfe
commit 162b937a80
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/platform/x86/amd-pmc.c
View File

@ -182,6 +182,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set)
out_unlock: out_unlock:
mutex_unlock(&dev->lock); mutex_unlock(&dev->lock);
amd_pmc_dump_registers(dev);
return rc; return rc;
} }
@ -194,7 +195,6 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev)
if (rc) if (rc)
dev_err(pdev->dev, "suspend failed\n"); dev_err(pdev->dev, "suspend failed\n");
amd_pmc_dump_registers(pdev);
return 0; return 0;
} }
@ -207,7 +207,6 @@ static int __maybe_unused amd_pmc_resume(struct device *dev)
if (rc) if (rc)
dev_err(pdev->dev, "resume failed\n"); dev_err(pdev->dev, "resume failed\n");
amd_pmc_dump_registers(pdev);
return 0; return 0;
} }
@ -279,8 +278,6 @@ static int amd_pmc_probe(struct platform_device *pdev)
if (!dev->regbase) if (!dev->regbase)
return -ENOMEM; return -ENOMEM;
amd_pmc_dump_registers(dev);
mutex_init(&dev->lock); mutex_init(&dev->lock);
platform_set_drvdata(pdev, dev); platform_set_drvdata(pdev, dev);
amd_pmc_dbgfs_register(dev); amd_pmc_dbgfs_register(dev);