UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

wmi: fix a memory leak in wmi_notify_debug 

When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.

The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
and thus must check its return value before accessing
or kfree() on the buffer.

This patch adds return value checking for wmi_get_event_data()
and adds a missing kfree(obj) in the end of wmi_notify_debug

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
Axel Lin 2010-06-28 09:30:45 +08:00 committed by Matthew Garrett
parent d5164dbf1f
commit 1492616a43
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/platform/x86/wmi.c
View File

@ -518,8 +518,13 @@ static void wmi_notify_debug(u32 value, void *context)
{ {
struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL }; struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
union acpi_object *obj; union acpi_object *obj;
acpi_status status;
wmi_get_event_data(value, &response); status = wmi_get_event_data(value, &response);
if (status != AE_OK) {
printk(KERN_INFO "wmi: bad event status 0x%x\n", status);
return;
}
obj = (union acpi_object *)response.pointer; obj = (union acpi_object *)response.pointer;
@ -543,6 +548,7 @@ static void wmi_notify_debug(u32 value, void *context)
default: default:
printk("object type 0x%X\n", obj->type); printk("object type 0x%X\n", obj->type);
} }
kfree(obj);
} }
/** /**