UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

drivers/firmware/psci: Assign @err directly in hotplug_tests() 

The return value of down_and_up_cpus() can be assigned to @err directly.
With that, the useless assignment to @err with zero can be dropped.

Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20200630075943.203954-1-gshan@redhat.com
Signed-off-by: Will Deacon <will@kernel.org>
This commit is contained in:
Gavin Shan 2020-06-30 17:59:43 +10:00 committed by Will Deacon
parent c377e67c62
commit 132330f804
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/firmware/psci/psci_checker.c
View File

@ -199,13 +199,12 @@ static int hotplug_tests(void)
if (!page_buf) if (!page_buf)
goto out_free_cpu_groups; goto out_free_cpu_groups;
err = 0;
/* /*
* Of course the last CPU cannot be powered down and cpu_down() should * Of course the last CPU cannot be powered down and cpu_down() should
* refuse doing that. * refuse doing that.
*/ */
pr_info("Trying to turn off and on again all CPUs\n"); pr_info("Trying to turn off and on again all CPUs\n");
err += down_and_up_cpus(cpu_online_mask, offlined_cpus); err = down_and_up_cpus(cpu_online_mask, offlined_cpus);
/* /*
* Take down CPUs by cpu group this time. When the last CPU is turned * Take down CPUs by cpu group this time. When the last CPU is turned