UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: wilc1000: txq_thread_started: replaces a semaphore with a completion 

This patch replaces a semaphore(txq_thread_started) with a completion.
Struct semaphore txq_thread_started is used to signal completion of txq thread.
It is better to use completion than semaphore for this case.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Leo Kim 2016-04-01 17:44:15 +09:00 committed by Greg Kroah-Hartman
parent 01c7cee913
commit 11a54b3f99
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/wilc1000/linux_wlan.c
View File

@ -22,6 +22,7 @@
#include <linux/skbuff.h>
#include <linux/semaphore.h>
#include <linux/completion.h>
static int dev_state_ev_handler(struct notifier_block *this,
unsigned long event, void *ptr);
@ -313,12 +314,12 @@ static int linux_wlan_txq_task(void *vp)
vif = netdev_priv(dev);
wl = vif->wilc;
up(&wl->txq_thread_started);
complete(&wl->txq_thread_started);
while (1) {
down(&wl->txq_event);
if (wl->close) {
up(&wl->txq_thread_started);
complete(&wl->txq_thread_started);
while (!kthread_should_stop())
schedule();
@ -693,8 +694,7 @@ static int wlan_init_locks(struct net_device *dev)
sema_init(&wl->cfg_event, 0);
sema_init(&wl->sync_event, 0);
sema_init(&wl->txq_thread_started, 0);
init_completion(&wl->txq_thread_started);
return 0;
}
@ -731,7 +731,7 @@ static int wlan_initialize_threads(struct net_device *dev)
wilc->close = 0;
return -ENOBUFS;
}
down(&wilc->txq_thread_started);
wait_for_completion(&wilc->txq_thread_started);
return 0;
}

3
drivers/staging/wilc1000/wilc_wfi_netdevice.h
View File

@ -179,8 +179,7 @@ struct wilc {
struct semaphore cfg_event;
struct semaphore sync_event;
struct semaphore txq_event;
struct semaphore txq_thread_started;
struct completion txq_thread_started;
struct task_struct *txq_thread;