lockd: fix nlm_close_files

This loop condition tries a bit too hard to be clever. Just test for
the two indices we care about explicitly.

Cc: J. Bruce Fields <bfields@fieldses.org>
Fixes: 7f024fcd5c ("Keep read and write fds with each nlm_file")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This commit is contained in:
Jeff Layton 2022-07-11 14:30:14 -04:00 committed by Chuck Lever
parent aec158242b
commit 1197eb5906
1 changed files with 4 additions and 5 deletions

View File

@ -283,11 +283,10 @@ nlm_file_inuse(struct nlm_file *file)
static void nlm_close_files(struct nlm_file *file) static void nlm_close_files(struct nlm_file *file)
{ {
struct file *f; if (file->f_file[O_RDONLY])
nlmsvc_ops->fclose(file->f_file[O_RDONLY]);
for (f = file->f_file[0]; f <= file->f_file[1]; f++) if (file->f_file[O_WRONLY])
if (f) nlmsvc_ops->fclose(file->f_file[O_WRONLY]);
nlmsvc_ops->fclose(f);
} }
/* /*