VIDEO: Correct use of request_region/request_mem_region
request_region should be used with release_region, not request_mem_region. Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c, the problem is actually the other way around; request_mem_region should be used instead of request_region. The semantic patch that finds/fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ expression start; @@ request_region(start,...) @b1@ expression r1.start; @@ request_mem_region(start,...) @depends on !b1@ expression r1.start; expression E; @@ - release_mem_region + release_region (start,E) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
parent
dbf763a2f1
commit
0fdd07f77f
|
@ -1147,7 +1147,7 @@ static int __init gbefb_probe(struct platform_device *p_dev)
|
|||
gbefb_setup(options);
|
||||
#endif
|
||||
|
||||
if (!request_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
|
||||
if (!request_mem_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
|
||||
printk(KERN_ERR "gbefb: couldn't reserve mmio region\n");
|
||||
ret = -EBUSY;
|
||||
goto out_release_framebuffer;
|
||||
|
|
Loading…
Reference in New Issue