UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

Btrfs: fix panic in balance due to EIO 

During build_backref_tree(), if we fail to read a btree node,
we can eventually run into BUG_ON(cache->nr_nodes) that we put
in backref_cache_cleanup(), meaning we have at least one
memory leak.

This frees the backref_node that we's allocated at the very
beginning of build_backref_tree().

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Liu Bo 2016-07-12 10:29:37 -07:00 committed by David Sterba
parent baf863b9c2
commit 0fd8c3dae1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/btrfs/relocation.c
View File

@ -1171,8 +1171,12 @@ out:
lower = list_entry(useless.next, lower = list_entry(useless.next,
struct backref_node, list); struct backref_node, list);
list_del_init(&lower->list); list_del_init(&lower->list);
if (lower == node)
node = NULL;
free_backref_node(cache, lower); free_backref_node(cache, lower);
} }
free_backref_node(cache, node);
return ERR_PTR(err); return ERR_PTR(err);
} }
ASSERT(!node || !node->detached); ASSERT(!node || !node->detached);