UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

arm64: assembler: Update comment above cond_yield_neon() macro 

Since commit 7faa313f05 ("arm64: preempt: Fix big-endian when checking
preempt count in assembly") both the preempt count and the 'need_resched'
flag are checked as part of a single 64-bit load in cond_yield_neon(),
so update the stale comment to reflect reality.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
Hillf Danton 2019-05-14 16:34:19 +08:00 committed by Will Deacon
parent 14ae42a6f0
commit 0e4add4ae7
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
arch/arm64/include/asm/assembler.h
View File

@ -718,12 +718,11 @@ USER(\label, ic ivau, \tmp2) // invalidate I line PoU
* the output section, any use of such directives is undefined. * the output section, any use of such directives is undefined.
* *
* The yield itself consists of the following: * The yield itself consists of the following:
* - Check whether the preempt count is exactly 1, in which case disabling * - Check whether the preempt count is exactly 1 and a reschedule is also
* preemption once will make the task preemptible. If this is not the case, * needed. If so, calling of preempt_enable() in kernel_neon_end() will
* yielding is pointless. * trigger a reschedule. If it is not the case, yielding is pointless.
* - Check whether TIF_NEED_RESCHED is set, and if so, disable and re-enable * - Disable and re-enable kernel mode NEON, and branch to the yield fixup
* kernel mode NEON (which will trigger a reschedule), and branch to the * code.
* yield fixup code.
* *
* This macro sequence may clobber all CPU state that is not guaranteed by the * This macro sequence may clobber all CPU state that is not guaranteed by the
* AAPCS to be preserved across an ordinary function call. * AAPCS to be preserved across an ordinary function call.