UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: xscale: Fix return type for implementation of ndo_start_xmit 

Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

eth_xmit() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so
change the return type to netdev_tx_t directly.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20220902081612.60405-1-guozihua@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
GUO Zihua 2022-09-02 16:16:12 +08:00 committed by Jakub Kicinski
parent 12f7bd2522
commit 0dbaf0fa62
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/xscale/ixp4xx_eth.c
View File

@ -841,7 +841,7 @@ static void eth_txdone_irq(void *unused)
} }
} }
static int eth_xmit(struct sk_buff *skb, struct net_device *dev) static netdev_tx_t eth_xmit(struct sk_buff *skb, struct net_device *dev)
{ {
struct port *port = netdev_priv(dev); struct port *port = netdev_priv(dev);
unsigned int txreadyq = port->plat->txreadyq; unsigned int txreadyq = port->plat->txreadyq;