scsi: lpfc: Correct some pretty obvious misdocumentation
Either due to API slippage before the driver was mainlined or copy/paste errors. Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_nvme.c:254: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_create_queue' drivers/scsi/lpfc/lpfc_nvme.c:254: warning: Function parameter or member 'qsize' not described in 'lpfc_nvme_create_queue' drivers/scsi/lpfc/lpfc_nvme.c:254: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_create_queue' drivers/scsi/lpfc/lpfc_nvme.c:311: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_delete_queue' drivers/scsi/lpfc/lpfc_nvme.c:311: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_delete_queue' drivers/scsi/lpfc/lpfc_nvme.c:689: warning: Function parameter or member 'gen_req_cmp' not described in '__lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:801: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:801: warning: Function parameter or member 'pnvme_rport' not described in 'lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:801: warning: Function parameter or member 'pnvme_lsreq' not described in 'lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:801: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:801: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_ls_req' drivers/scsi/lpfc/lpfc_nvme.c:937: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_ls_abort' drivers/scsi/lpfc/lpfc_nvme.c:937: warning: Function parameter or member 'pnvme_rport' not described in 'lpfc_nvme_ls_abort' drivers/scsi/lpfc/lpfc_nvme.c:937: warning: Function parameter or member 'pnvme_lsreq' not described in 'lpfc_nvme_ls_abort' drivers/scsi/lpfc/lpfc_nvme.c:937: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_ls_abort' drivers/scsi/lpfc/lpfc_nvme.c:937: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_ls_abort' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Function parameter or member 'phba' not described in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Function parameter or member 'pwqeIn' not described in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Function parameter or member 'wcqe' not described in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1075: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Function parameter or member 'lpfc_ncmd' not described in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Function parameter or member 'pnode' not described in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Function parameter or member 'cstat' not described in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Excess function parameter 'lpfc_nvme_fcreq' description in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1313: warning: Excess function parameter 'hw_queue_handle' description in 'lpfc_nvme_prep_io_cmd' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Function parameter or member 'lpfc_ncmd' not described in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Excess function parameter 'lpfc_nvme_fcreq' description in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1420: warning: Excess function parameter 'hw_queue_handle' description in 'lpfc_nvme_prep_io_dma' drivers/scsi/lpfc/lpfc_nvme.c:1598: warning: bad line: indicated in @lpfc_nvme_rport. drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Function parameter or member 'pnvme_rport' not described in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Function parameter or member 'pnvme_fcreq' not described in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1609: warning: Excess function parameter 'lpfc_nvme_fcreq' description in 'lpfc_nvme_fcp_io_submit' drivers/scsi/lpfc/lpfc_nvme.c:1856: warning: Function parameter or member 'abts_cmpl' not described in 'lpfc_nvme_abort_fcreq_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1856: warning: Excess function parameter 'rspiocb' description in 'lpfc_nvme_abort_fcreq_cmpl' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Function parameter or member 'pnvme_rport' not described in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Function parameter or member 'pnvme_fcreq' not described in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Excess function parameter 'lpfc_pnvme' description in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Excess function parameter 'lpfc_nvme_lport' description in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Excess function parameter 'lpfc_nvme_rport' description in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:1892: warning: Excess function parameter 'lpfc_nvme_fcreq' description in 'lpfc_nvme_fcp_abort' drivers/scsi/lpfc/lpfc_nvme.c:2093: warning: Function parameter or member 'ndlp' not described in 'lpfc_get_nvme_buf' drivers/scsi/lpfc/lpfc_nvme.c:2093: warning: Function parameter or member 'idx' not described in 'lpfc_get_nvme_buf' drivers/scsi/lpfc/lpfc_nvme.c:2093: warning: Function parameter or member 'expedite' not described in 'lpfc_get_nvme_buf' drivers/scsi/lpfc/lpfc_nvme.c:2197: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_create_localport' drivers/scsi/lpfc/lpfc_nvme.c:2330: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_destroy_localport' drivers/scsi/lpfc/lpfc_nvme.c:2330: warning: Excess function parameter 'pnvme' description in 'lpfc_nvme_destroy_localport' drivers/scsi/lpfc/lpfc_nvme.c:2543: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_rescan_port' drivers/scsi/lpfc/lpfc_nvme.c:2543: warning: Function parameter or member 'ndlp' not described in 'lpfc_nvme_rescan_port' Link: https://lore.kernel.org/r/20200713080001.128044-21-lee.jones@linaro.org Cc: James Smart <james.smart@broadcom.com> Cc: Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Lee Jones
Martin K. Petersen
parent
7405edfdfb
commit
09d99705b5
|
|
@ -234,8 +234,10 @@ lpfc_nvme_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
|
|||
|
||||
/**
|
||||
* lpfc_nvme_create_queue -
|
||||
* @pnvme_lport: Transport localport that LS is to be issued from
|
||||
* @lpfc_pnvme: Pointer to the driver's nvme instance data
|
||||
* @qidx: An cpu index used to affinitize IO queues and MSIX vectors.
|
||||
* @qsize: Size of the queue in bytes
|
||||
* @handle: An opaque driver handle used in follow-up calls.
|
||||
*
|
||||
* Driver registers this routine to preallocate and initialize any
|
||||
|
|
@ -292,7 +294,7 @@ lpfc_nvme_create_queue(struct nvme_fc_local_port *pnvme_lport,
|
|||
|
||||
/**
|
||||
* lpfc_nvme_delete_queue -
|
||||
* @lpfc_pnvme: Pointer to the driver's nvme instance data
|
||||
* @pnvme_lport: Transport localport that LS is to be issued from
|
||||
* @qidx: An cpu index used to affinitize IO queues and MSIX vectors.
|
||||
* @handle: An opaque driver handle from lpfc_nvme_create_queue
|
||||
*
|
||||
|
|
@ -672,6 +674,7 @@ lpfc_nvme_gen_req(struct lpfc_vport *vport, struct lpfc_dmabuf *bmp,
|
|||
* @vport: The local port issuing the LS
|
||||
* @ndlp: The remote port to send the LS to
|
||||
* @pnvme_lsreq: Pointer to LS request structure from the transport
|
||||
* @gen_req_cmp: Completion call-back
|
||||
*
|
||||
* Routine validates the ndlp, builds buffers and sends a GEN_REQUEST
|
||||
* WQE to perform the LS operation.
|
||||
|
|
@ -783,9 +786,9 @@ __lpfc_nvme_ls_req(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
|
|||
|
||||
/**
|
||||
* lpfc_nvme_ls_req - Issue an NVME Link Service request
|
||||
* @lpfc_nvme_lport: Transport localport that LS is to be issued from.
|
||||
* @lpfc_nvme_rport: Transport remoteport that LS is to be sent to.
|
||||
* @pnvme_lsreq - the transport nvme_ls_req structure for the LS
|
||||
* @pnvme_lport: Transport localport that LS is to be issued from.
|
||||
* @nvme_rport: Transport remoteport that LS is to be sent to.
|
||||
* @pnvme_lsreq: the transport nvme_ls_req structure for the LS
|
||||
*
|
||||
* Driver registers this routine to handle any link service request
|
||||
* from the nvme_fc transport to a remote nvme-aware port.
|
||||
|
|
@ -923,9 +926,9 @@ lpfc_nvme_xmt_ls_rsp(struct nvme_fc_local_port *localport,
|
|||
|
||||
/**
|
||||
* lpfc_nvme_ls_abort - Abort a prior NVME LS request
|
||||
* @lpfc_nvme_lport: Transport localport that LS is to be issued from.
|
||||
* @lpfc_nvme_rport: Transport remoteport that LS is to be sent to.
|
||||
* @pnvme_lsreq - the transport nvme_ls_req structure for the LS
|
||||
* @pnvme_lport: Transport localport that LS is to be issued from.
|
||||
* @pnvme_rport: Transport remoteport that LS is to be sent to.
|
||||
* @pnvme_lsreq: the transport nvme_ls_req structure for the LS
|
||||
*
|
||||
* Driver registers this routine to abort a NVME LS request that is
|
||||
* in progress (from the transports perspective).
|
||||
|
|
@ -1055,11 +1058,8 @@ lpfc_nvme_adj_fcp_sgls(struct lpfc_vport *vport,
|
|||
}
|
||||
|
||||
|
||||
/**
|
||||
/*
|
||||
* lpfc_nvme_io_cmd_wqe_cmpl - Complete an NVME-over-FCP IO
|
||||
* @lpfc_pnvme: Pointer to the driver's nvme instance data
|
||||
* @lpfc_nvme_lport: Pointer to the driver's local port data
|
||||
* @lpfc_nvme_rport: Pointer to the rport getting the @lpfc_nvme_ereq
|
||||
*
|
||||
* Driver registers this routine as it io request handler. This
|
||||
* routine issues an fcp WQE with data from the @lpfc_nvme_fcpreq
|
||||
|
|
@ -1291,11 +1291,10 @@ out_err:
|
|||
|
||||
/**
|
||||
* lpfc_nvme_prep_io_cmd - Issue an NVME-over-FCP IO
|
||||
* @lpfc_pnvme: Pointer to the driver's nvme instance data
|
||||
* @lpfc_nvme_lport: Pointer to the driver's local port data
|
||||
* @lpfc_nvme_rport: Pointer to the rport getting the @lpfc_nvme_ereq
|
||||
* @lpfc_nvme_fcreq: IO request from nvme fc to driver.
|
||||
* @hw_queue_handle: Driver-returned handle in lpfc_nvme_create_queue
|
||||
* @vport: pointer to a host virtual N_Port data structure
|
||||
* @lpfcn_cmd: Pointer to lpfc scsi command
|
||||
* @pnode: pointer to a node-list data structure
|
||||
* @cstat: pointer to the control status structure
|
||||
*
|
||||
* Driver registers this routine as it io request handler. This
|
||||
* routine issues an fcp WQE with data from the @lpfc_nvme_fcpreq
|
||||
|
|
@ -1400,11 +1399,8 @@ lpfc_nvme_prep_io_cmd(struct lpfc_vport *vport,
|
|||
|
||||
/**
|
||||
* lpfc_nvme_prep_io_dma - Issue an NVME-over-FCP IO
|
||||
* @lpfc_pnvme: Pointer to the driver's nvme instance data
|
||||
* @lpfc_nvme_lport: Pointer to the driver's local port data
|
||||
* @lpfc_nvme_rport: Pointer to the rport getting the @lpfc_nvme_ereq
|
||||
* @lpfc_nvme_fcreq: IO request from nvme fc to driver.
|
||||
* @hw_queue_handle: Driver-returned handle in lpfc_nvme_create_queue
|
||||
* @vport: pointer to a host virtual N_Port data structure
|
||||
* @lpfcn_cmd: Pointer to lpfc scsi command
|
||||
*
|
||||
* Driver registers this routine as it io request handler. This
|
||||
* routine issues an fcp WQE with data from the @lpfc_nvme_fcpreq
|
||||
|
|
|
|||
Loading…
Reference in New Issue