module: drop version-attribute alignment
Commit98562ad8cb
("module: explicitly align module_version_attribute structure") added an alignment attribute to the struct module_version_attribute type in order to fix an alignment issue on m68k where the structure is 2-byte aligned while MODULE_VERSION() forced the __modver section entries to be 4-byte aligned (sizeof(void *)). This was essentially an alternative fix to the problem addressed byb4bc842802
("module: deal with alignment issues in built-in module versions") which used the array-of-pointer trick to prevent gcc from increasing alignment of the version attribute entries. And with the pointer indirection in place there's no need to increase the alignment of the type. Link: https://lore.kernel.org/lkml/20201103175711.10731-1-johan@kernel.org Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Jessica Yu <jeyu@kernel.org>
This commit is contained in:
parent
24b9f0d220
commit
0801a0073f
|
@ -66,7 +66,7 @@ struct module_version_attribute {
|
|||
struct module_attribute mattr;
|
||||
const char *module_name;
|
||||
const char *version;
|
||||
} __attribute__ ((__aligned__(sizeof(void *))));
|
||||
};
|
||||
|
||||
extern ssize_t __modver_version_show(struct module_attribute *,
|
||||
struct module_kobject *, char *);
|
||||
|
|
Loading…
Reference in New Issue