UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ptrace: Use copy_siginfo in setsiginfo and getsiginfo 

Now that copy_siginfo copies all of the fields this is safe, safer (as
all of the bits are guaranteed to be copied), clearer, and less error
prone than using a structure copy.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
This commit is contained in:
Eric W. Biederman 2017-07-24 15:08:16 -05:00
parent ea64d5acc8
commit 0752d7bf62
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/ptrace.c
View File

@ -659,7 +659,7 @@ static int ptrace_getsiginfo(struct task_struct *child, siginfo_t *info)
if (lock_task_sighand(child, &flags)) { if (lock_task_sighand(child, &flags)) {
error = -EINVAL; error = -EINVAL;
if (likely(child->last_siginfo != NULL)) { if (likely(child->last_siginfo != NULL)) {
*info = *child->last_siginfo; copy_siginfo(info, child->last_siginfo);
error = 0; error = 0;
} }
unlock_task_sighand(child, &flags); unlock_task_sighand(child, &flags);
@ -675,7 +675,7 @@ static int ptrace_setsiginfo(struct task_struct *child, const siginfo_t *info)
if (lock_task_sighand(child, &flags)) { if (lock_task_sighand(child, &flags)) {
error = -EINVAL; error = -EINVAL;
if (likely(child->last_siginfo != NULL)) { if (likely(child->last_siginfo != NULL)) {
*child->last_siginfo = *info; copy_siginfo(child->last_siginfo, info);
error = 0; error = 0;
} }
unlock_task_sighand(child, &flags); unlock_task_sighand(child, &flags);