UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

iio: adc: max1241: Make use of the helper function dev_err_probe() 

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20211008092858.495-5-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Cai Huoqing 2021-10-08 17:28:53 +08:00 committed by Jonathan Cameron
parent 9444794b58
commit 070a83ff63
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/iio/adc/max1241.c
View File

@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi)
mutex_init(&adc->lock); mutex_init(&adc->lock);
adc->vdd = devm_regulator_get(dev, "vdd"); adc->vdd = devm_regulator_get(dev, "vdd");
if (IS_ERR(adc->vdd)) { if (IS_ERR(adc->vdd))
dev_err(dev, "failed to get vdd regulator\n"); return dev_err_probe(dev, PTR_ERR(adc->vdd),
return PTR_ERR(adc->vdd); "failed to get vdd regulator\n");
}
ret = regulator_enable(adc->vdd); ret = regulator_enable(adc->vdd);
if (ret) if (ret)
@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi)
} }
adc->vref = devm_regulator_get(dev, "vref"); adc->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(adc->vref)) { if (IS_ERR(adc->vref))
dev_err(dev, "failed to get vref regulator\n"); return dev_err_probe(dev, PTR_ERR(adc->vref),
return PTR_ERR(adc->vref); "failed to get vref regulator\n");
}
ret = regulator_enable(adc->vref); ret = regulator_enable(adc->vref);
if (ret) if (ret)
@ -182,7 +180,8 @@ static int max1241_probe(struct spi_device *spi)
adc->shutdown = devm_gpiod_get_optional(dev, "shutdown", adc->shutdown = devm_gpiod_get_optional(dev, "shutdown",
GPIOD_OUT_HIGH); GPIOD_OUT_HIGH);
if (IS_ERR(adc->shutdown)) if (IS_ERR(adc->shutdown))
return PTR_ERR(adc->shutdown); return dev_err_probe(dev, PTR_ERR(adc->shutdown),
"cannot get shutdown gpio\n");
if (adc->shutdown) if (adc->shutdown)
dev_dbg(dev, "shutdown pin passed, low-power mode enabled"); dev_dbg(dev, "shutdown pin passed, low-power mode enabled");