UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

sctp: fix a potential OOB access in sctp_sched_set_sched() 

The 'sched' index value must be checked before accessing an element
of the 'sctp_sched_ops' array. Otherwise, it can lead to OOB access.

Note that it's harmless since the 'sched' parameter is checked before
calling 'sctp_sched_set_sched'.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ilia.Gavrilov 2023-05-10 09:23:40 +00:00 committed by David S. Miller
parent 6096bc0555
commit 059fa49202
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
net/sctp/stream_sched.c
View File

@ -148,18 +148,19 @@ static void sctp_sched_free_sched(struct sctp_stream *stream)
int sctp_sched_set_sched(struct sctp_association *asoc, int sctp_sched_set_sched(struct sctp_association *asoc,
enum sctp_sched_type sched) enum sctp_sched_type sched)
{ {
struct sctp_sched_ops *n = sctp_sched_ops[sched];
struct sctp_sched_ops *old = asoc->outqueue.sched; struct sctp_sched_ops *old = asoc->outqueue.sched;
struct sctp_datamsg *msg = NULL; struct sctp_datamsg *msg = NULL;
struct sctp_sched_ops *n;
struct sctp_chunk *ch; struct sctp_chunk *ch;
int i, ret = 0; int i, ret = 0;
if (old == n)
return ret;
if (sched > SCTP_SS_MAX) if (sched > SCTP_SS_MAX)
return -EINVAL; return -EINVAL;
n = sctp_sched_ops[sched];
if (old == n)
return ret;
if (old) if (old)
sctp_sched_free_sched(&asoc->stream); sctp_sched_free_sched(&asoc->stream);