UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

mac80211: remove STA txq pending airtime underflow warning 

This warning can trigger if there is a mismatch between frames that were
sent with the sta pointer set vs tx status frames reported for the sta address.

This can happen due to race conditions on re-creating stations, or even
in the case of .sta_add/remove being used instead of .sta_state, which can cause
frames to be sent to a station that has not been uploaded yet.

If there is an actual underflow issue, it should show up in the device airtime
warning below, so it is better to remove this one.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20200725084533.13829-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Felix Fietkau 2020-07-25 10:45:33 +02:00 committed by Johannes Berg
parent e61fbfca80
commit 04e35caa32
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/mac80211/sta_info.c
View File

@ -1923,9 +1923,7 @@ void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local,
if (sta) { if (sta) {
tx_pending = atomic_sub_return(tx_airtime, tx_pending = atomic_sub_return(tx_airtime,
&sta->airtime[ac].aql_tx_pending); &sta->airtime[ac].aql_tx_pending);
if (WARN_ONCE(tx_pending < 0, if (tx_pending < 0)
"STA %pM AC %d txq pending airtime underflow: %u, %u",
sta->addr, ac, tx_pending, tx_airtime))
atomic_cmpxchg(&sta->airtime[ac].aql_tx_pending, atomic_cmpxchg(&sta->airtime[ac].aql_tx_pending,
tx_pending, 0); tx_pending, 0);
} }